Permalink
Browse files

types: remove Sidecars field from ReleaseEnvironment

  • Loading branch information...
isutton authored and kanatohodets committed Dec 5, 2018
1 parent 5e21c06 commit 8d742aabe56dd82111b8fae7c74156d9958ba589
@@ -59,19 +59,6 @@ spec:
type: string
repoUrl:
type: string
sidecars:
type: array
nullable: true
items:
type: object
required:
- name
- version
properties:
name:
type: string
version:
type: string
clusterRequirements:
type: object
required:
@@ -26,11 +26,6 @@ metadata:
image:
name: reviewsapi/app
version: 6bbb0da1891646e58eb3e6a63af3a6fc3c8eb5a0d44824cba581d2e14a0450cf
sidecars:
- name: envoy
version: "2.1"
- name: telegraf
version: "0.99"
strategy:
steps:
- name: staging
@@ -231,20 +231,12 @@ type ReleaseEnvironment struct {
// XXX pointer here means it's null-able, do we want that?
Values *ChartValues `json:"values"`

// set of sidecars to inject into the chart on rendering
Sidecars []Sidecar `json:"sidecars"`

// requirements for target clusters for the deployment
ClusterRequirements ClusterRequirements `json:"clusterRequirements"`

Strategy *RolloutStrategy `json:"strategy,omitempty"`
}

type Sidecar struct {
Name string `json:"name"`
Version string `json:"version"`
}

type ClusterRequirements struct {
// it is an error to not specify any regions
Regions []RegionRequirement `json:"regions"`
@@ -847,11 +847,6 @@ func (in *ReleaseEnvironment) DeepCopyInto(out *ReleaseEnvironment) {
(*in).DeepCopyInto(*out)
}
}
if in.Sidecars != nil {
in, out := &in.Sidecars, &out.Sidecars
*out = make([]Sidecar, len(*in))
copy(*out, *in)
}
in.ClusterRequirements.DeepCopyInto(&out.ClusterRequirements)
if in.Strategy != nil {
in, out := &in.Strategy, &out.Strategy

0 comments on commit 8d742aa

Please sign in to comment.