Permalink
Branch: master
Commits on Feb 12, 2019
  1. Merge pull request #66 from bookingcom/btyler/lint-fixes

    parhamdoustdar committed Feb 12, 2019
    lint fixups
Commits on Feb 9, 2019
  1. lint: vetshadow fixes + ignore 'err' shadowing

    kanatohodets committed Feb 9, 2019
    vetshadow can be very useful. However, shadowing 'err' is incredibly
    common, rarely harmful, and requires writing non-idiomatic Go in order
    to avoid. So, let's filter that out.
  2. lint: fix missing error checks (errcheck)

    kanatohodets committed Feb 9, 2019
    One minor bug fixed: bash filename autocompletion for shipperctl apply
    was not working.
    
    One minor judgement call: if we can't set up /metrics, this is a fatal
    error.
    
    Examples:
    
    cmd/shipper-state-metrics/main.go:95:21⚠️ error return value not
    checked (srv.ListenAndServe()) (errcheck)
    
    cmd/shipper/main.go:255:20⚠️ error return value not checked
    (srv.ListenAndServe()) (errcheck)
    
    cmd/shipperctl/cmd/apply.go:47:27⚠️ error return value not
    checked (applyCmd.MarkFlagFilename("config", "yaml")) (errcheck)
    
    cmd/shipperctl/cmd/apply.go:48:27⚠️ error return value not
    checked (applyCmd.MarkFlagFilename("kube-config", "yaml")) (errcheck)
    
    cmd/shipperctl/cmd/apply.go:387:16⚠️ error return value not
    checked (yaml.Unmarshal(configBytes, configuration)) (errcheck)
  3. lint: unreachable cases in type switches (staticcheck SA4020)

    kanatohodets committed Feb 9, 2019
    The patch in traffic/errors.go is a targeted fix; the larger scale
    solution is to implement structured errors throughout Shipper.
    
    (kudos to @ksurent, who implemented this new check in staticcheck)
    
    Examples:
    
    pkg/testing/util.go:182:2⚠️ unreachable case clause:
    github.com/bookingcom/shipper/vendor/k8s.io/client-go/testing.CreateAction
    will always match before
    github.com/bookingcom/shipper/vendor/k8s.io/client-go/testing.UpdateAction
    (SA4020) (staticcheck)
    
    pkg/testing/util.go:197:2⚠️ unreachable case clause:
    github.com/bookingcom/shipper/vendor/k8s.io/client-go/testing.GetAction
    will always match before
    github.com/bookingcom/shipper/vendor/k8s.io/client-go/testing.DeleteAction
    (SA4020) (staticcheck)
  4. lint: skip ignored receivers (staticcheck ST1006)

    kanatohodets committed Feb 9, 2019
    Examples:
    
    cmd/shipper-state-metrics/main.go:119:7⚠️ receiver name should
    not be an underscore, omit the name if it is unused (ST1006)
    (staticcheck)
    
    cmd/shipper/main.go:234:7⚠️ receiver name should not be an
    underscore, omit the name if it is unused (ST1006) (staticcheck)
  5. lint: style fixes for error strings (staticcheck ST1005)

    kanatohodets committed Feb 9, 2019
    Examples:
    
    pkg/chart/cache/cache.go:94:20⚠️ error strings should not end
    with punctuation or a newline (ST1005) (staticcheck)
    
    pkg/clusterclientstore/queue.go:48:37⚠️ error strings should not
    be capitalized (ST1005) (staticcheck)
  6. lint: simplify loop declaration (staticcheck S1005)

    kanatohodets committed Feb 8, 2019
    Example:
    
    pkg/controller/traffic/pod_label_shifter.go:55:15⚠️ should omit
    value from range; this loop is equivalent to `for cluster := range ...`
    (S1005) (staticcheck)
Commits on Feb 8, 2019
  1. ci: update metalinter config

    kanatohodets committed Feb 8, 2019
    megacheck was merged into staticcheck
Commits on Feb 1, 2019
  1. Applied a fix for installer: an empty Labels map in chosenService was…

    icanhazbroccoli authored and kanatohodets committed Jan 29, 2019
    … breaking the pipeline
Commits on Jan 25, 2019
  1. codegen: re-run codegen to update copyright date

    kanatohodets committed Jan 25, 2019
Commits on Dec 24, 2018
  1. shipperctl: sync CRD openAPI validation with yaml

    kanatohodets committed Dec 21, 2018
  2. types: Remove Sidecar DeepCopyInto

    isutton authored and kanatohodets committed Dec 6, 2018
  3. crds: sidecars can be nullable.

    isutton authored and kanatohodets committed Dec 3, 2018
Commits on Dec 20, 2018
  1. readme: add note about Tiller

    kanatohodets committed Dec 20, 2018
    (or lack thereof)
Commits on Dec 19, 2018
  1. docs: add note about issue GKE cluster names

    kanatohodets committed Dec 19, 2018
    shipperctl's usage of the context name for the Cluster object fails if that context name is not an acceptable Kubernetes object name, as is the case in GKE clusters and their underscores.
    
    This helps people work around the issue in #61, but a better fix will be for shipperctl to give immediate feedback when it detects that issue.
Commits on Dec 14, 2018
  1. Added documentation for shipperctl.

    parhamdoustdar committed Dec 14, 2018
Commits on Dec 11, 2018
  1. Merge pull request #58 from artjock/patch-1

    parhamdoustdar committed Dec 11, 2018
    Removing extra bracket
  2. Removing extra bracket

    artjock committed Dec 11, 2018
Commits on Dec 10, 2018
  1. docs: fix contact links

    kanatohodets committed Dec 10, 2018
  2. shipperctl: add support for external auth providers

    kanatohodets committed Dec 10, 2018
    This allows it to work with, for example, GKE clusters with the 'gcp'
    auth provider in ~/.kube/config.
    
    Also tweak the quick install docs to mention that you need to be a real
    cluster-admin. On GKE you need to create a clusterrolebinding first;
    otherwise you see errors that indicate trying to create the new Shipper
    clusterroles is privilege escalation.
    
    This commit includes a giant pile of new stuff in vendor: this is
    everything all of the cloud providers for their auth plugins.
  3. ci: don't skip tags

    kanatohodets committed Dec 10, 2018
    Previous change to build docker images on tags was early-exiting because
    the branch wasn't master.
  4. docs: limitations

    kanatohodets committed Dec 9, 2018
  5. docs: swap 'install' for 'developer'

    kanatohodets committed Dec 9, 2018
    this can become the tree for contributor docs
  6. docs: shift rollout example to user guide

    kanatohodets committed Dec 9, 2018
    And migrate some content from the API reference style rollout doc that
    we already had
  7. Dockerfiles: add CA certs, remove PATH truncation

    kanatohodets committed Dec 9, 2018
    Forcing PATH like that makes the container feel very odd if you exec
    into it. CA certs are nice if you want to download Helm charts over SSL.
Commits on Dec 9, 2018
  1. README update

    kanatohodets committed Dec 9, 2018
Commits on Dec 8, 2018
  1. isutton/docs-scaffold (#53)

    isutton authored and kanatohodets committed Dec 8, 2018
    * docs: initial commit
    
    * docs: add deployment.rst
    
    * docs: more docs
    
    * docs: more docs
    
    * docs: more docs
    
    * docs: clean docs
    
    * docs: more docs
    
    * docs: Add Dockerfile for documentation builder
    
    * docs/application: explain what happens when an application object is created
    
    * docs: add more information in Application's "Scope of control" section
    
    * docs: add more Release docs
    
    * docs: expand InstallationTarget concept documentation
    
    * docs: re-touch intro
    
    * docs: api reference draft
    
    * docs: add quick install guide
    
    The start/concepts bits were mostly replaced by the API reference docs.
    
    There's more there that isn't covered, mostly pertaining to
    architecture, which still needs to find a home.
    
    * ci: build release tagged images
    
    * docs: start fleshing out administrator's guide
    
    This involved moving application developer docs out of 'operations' to
    'user'.