Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade client-go #104

merged 11 commits into from Jul 3, 2019


None yet
4 participants
Copy link

commented Jun 19, 2019

Closes #93

Copy link

left a comment

Remove ~2,100,000 lines of code without a loss in functionality? Achievement unlocked!

Not sure how much review there is to do here beyond seeing that the tests pass and being a bit conservative in the rollout strategy, so LGTM. Many thanks for purging some of the old CI hacks.

Super nice work @parhamdoustdar and @juliogreff!

parhamdoustdar and others added some commits Jun 18, 2019

ci: remove dep artifacts
Now that we have moved to Go Modules, we no longer need to keep Gopkg
files (dependencies are now managed by go.mod and go.sum), nor do we
need to install and call `dep` in our CI pipeline. Instead, now we just
call `go mod verify`, and ensure that all go commands use the vendored
version of libraries by specifying `-mod=vendor`.
ci: upgrade golang to 1.12
We can't really use modules in 1.10. Also, we have successfully ran
shipper built with 1.12, so that's the reasonable thing to do.
ci: skip hack when linting/testing/building shipper
Since hack/tools.go got introduced, trying to build /hack/ fails with:

	hack/tools.go:4:8:error: build constraints exclude all Go files
	in vendor/

We could just add a build tag to make it compile, but there's not much
of a gain there, so let's just skip it completely instead.
ci: cut down on the amount of stuff we download
1. The kubernetes was only needed because of an older version of Now that it's been upgraded, it's no longer

2. kubectl is not needed since microk8s already installs a version of
that. For convenience, we alias `kubectl` to `microk8s.kubectl`
tests: finish refactoring for upgraded client-go
client-go's fake dynamic client no longer contains actions from the
non-dynamic client, so we had to split up, and sometimes join, lists of
actions so they could be checked properly.

With this, now all the unit tests pass with new client-go \o/

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

Rebased against new master because of conflicts, should be able to merge cleanly now.

Show resolved Hide resolved pkg/testing/util.go
Show resolved Hide resolved pkg/controller/installation/utils_test.go Outdated

@icanhazbroccoli icanhazbroccoli merged commit 1ef3d3c into master Jul 3, 2019

2 checks passed

Travis CI - Branch Build Passed
Travis CI - Pull Request Build Passed

@icanhazbroccoli icanhazbroccoli deleted the client-go-1.14.x branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.