Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validating webhook: validate only create/update #113

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@juliogreff
Copy link
Contributor

commented Jul 5, 2019

We're not interested in validating deletes at this point. Additionally,
the webhook code doesn't currently handle those very well, failing with:

Error from server: admission webhook "shipper.booking.com"
denied the request: unexpected end of JSON input
validating webhook: validate only create/update
We're not interested in validating deletes at this point. Additionally,
the webhook code doesn't currently handle those very well, failing with:

	Error from server: admission webhook "shipper.booking.com"
	denied the request: unexpected end of JSON input

@icanhazbroccoli icanhazbroccoli merged commit 6e73541 into master Jul 8, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@icanhazbroccoli icanhazbroccoli deleted the jgreff/webhook-operations branch Jul 8, 2019

icanhazbroccoli added a commit that referenced this pull request Jul 8, 2019

validating webhook: validate only create/update (#113)
We're not interested in validating deletes at this point. Additionally,
the webhook code doesn't currently handle those very well, failing with:

	Error from server: admission webhook "shipper.booking.com"
	denied the request: unexpected end of JSON input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.