Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced ghodss/yaml with community-supported sigs.k8s.io/yaml #136

Merged
merged 2 commits into from Sep 13, 2019

Conversation

@icanhazbroccoli
Copy link
Contributor

commented Jul 30, 2019

This commit is a followup on a conversation in ghodss/yaml#50. In essence, the change is about switching to the community-supported clone of yaml library. This change is quite wanted as it moves Shipper forward to no dependency on the aforementioned non-supported library. At present, there are quite some dependencies left which are mainly required by outdated versions of supporting libraries shipper uses. Once all the referred projects transition to the newer version of the library, Shipper can finalise the upgrade.

Signed-off-by: Oleg Sidorov oleg.sidorov@booking.com

@juliogreff juliogreff force-pushed the olegs/sigs-yaml-lib branch from 1823ab0 to 1ded76b Aug 13, 2019
@icanhazbroccoli icanhazbroccoli force-pushed the olegs/sigs-yaml-lib branch from 1ded76b to 2cac6db Sep 5, 2019
icanhazbroccoli and others added 2 commits Jul 30, 2019
This commit is a followup on a conversation in
ghodss/yaml#50. In essence, the change is
about switching to the community-supported clone of yaml library.
This change is quite wanted as it moves Shipper forward to no dependency
on the aforementioned non-supported library. At present, there are quite
some dependencies left which are mainly required by outdated versions of
supporting libraries shipper uses. Once all the referred projects
transition to the newer version of the library, Shipper can finalize the
upgrade.

Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com>
Let's try to depend on the same yaml library across the codebase, so
we're not surprised by the difference in functionality.

For instance, recent changes to shipperctl
(9514014) didn't work because we
assumed yaml.v2 would read `json` annotations the same way
`sigs.k8s.io/yaml` does, which is not the case. So `yaml.Unmarshall`
wouldn't properly deserialize into shipper.ClusterSpec structs because
it wouldn't read the annotations present there.
@juliogreff juliogreff force-pushed the olegs/sigs-yaml-lib branch from 2cac6db to 2a238b8 Sep 12, 2019
@juliogreff juliogreff added this to the release-0.6 milestone Sep 13, 2019
@icanhazbroccoli icanhazbroccoli merged commit 5c328d6 into master Sep 13, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@icanhazbroccoli icanhazbroccoli deleted the olegs/sigs-yaml-lib branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.