New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Introduce shipperctl command line utility #29

Merged
merged 4 commits into from Nov 1, 2018

Conversation

Projects
None yet
4 participants
@isutton
Copy link
Contributor

isutton commented Oct 11, 2018

No description provided.

@parhamdoustdar parhamdoustdar force-pushed the rfcs/999-shipperctl-admin branch from 107e3ba to 0ae97cf Oct 30, 2018

@parhamdoustdar parhamdoustdar changed the title WIP: RFC: Introduce shipperctl command line utility RFC: Introduce shipperctl command line utility Oct 30, 2018

@parhamdoustdar parhamdoustdar requested review from kanatohodets and bookingcom/shipper Oct 30, 2018

@kanatohodets
Copy link
Contributor

kanatohodets left a comment

LGTM! Couple of minor comments to flesh things out

Show resolved Hide resolved rfcs/999-shipperctl-admin.adoc Outdated
Show resolved Hide resolved rfcs/999-shipperctl-admin.adoc

=== Set Up the Application Cluster

* Create the Namespace based on the `namespace` argument on the application cluster

This comment has been minimized.

@isutton

isutton Oct 31, 2018

Author Contributor

Should we support use cases where namespaces are created by another actor?

This comment has been minimized.

@parhamdoustdar

parhamdoustdar Oct 31, 2018

Contributor

Great point. I was going to add it to the RFC, but I saw that it is already mentioned in the second use case:

The second use case is to update the Cluster objects, or to re-do any of the steps that are necessary to add this cluster. For example, if a service account is already set up for Shipper, this command will skip that step. This makes this command idempotent, and allows it to be used for git-ops or any sort of pipeline.

Is this what you meant?


.Cluster configuration file example
[source,yaml]
----

This comment has been minimized.

@isutton

isutton Oct 31, 2018

Author Contributor

This file should have an envelope with metadata and spec.

@parhamdoustdar parhamdoustdar dismissed stale reviews from icanhazbroccoli and kanatohodets via 401d680 Oct 31, 2018

@kanatohodets kanatohodets merged commit a62dd9a into master Nov 1, 2018

@parhamdoustdar parhamdoustdar deleted the rfcs/999-shipperctl-admin branch Nov 20, 2018

kanatohodets added a commit that referenced this pull request Nov 23, 2018

RFC: Introduce shipperctl command line utility (#29)
* rfcs: add shipperctl admin rfc

* Changed the RFC to follow our latest discussions.

* Made tiny fixes.

* shipperctl admin rfc: add k8s envelope to cluster manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment