Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRFC: Introduce shipperctl command line utility #29
Conversation
icanhazbroccoli
approved these changes
Oct 12, 2018
icanhazbroccoli
reviewed
Oct 16, 2018
parhamdoustdar
dismissed
icanhazbroccoli’s
stale review
via
107e3ba
Oct 30, 2018
isutton
and others
added some commits
Sep 19, 2018
parhamdoustdar
force-pushed the
rfcs/999-shipperctl-admin
branch
from
107e3ba
to
0ae97cf
Oct 30, 2018
parhamdoustdar
changed the title
WIP: RFC: Introduce shipperctl command line utility
RFC: Introduce shipperctl command line utility
Oct 30, 2018
parhamdoustdar
requested review from
kanatohodets
and
bookingcom/shipper
Oct 30, 2018
isutton
reviewed
Oct 31, 2018
|
|
||
| === Set Up the Application Cluster | ||
|
|
||
| * Create the Namespace based on the `namespace` argument on the application cluster |
This comment has been minimized.
This comment has been minimized.
isutton
Oct 31, 2018
Author
Contributor
Should we support use cases where namespaces are created by another actor?
This comment has been minimized.
This comment has been minimized.
parhamdoustdar
Oct 31, 2018
Contributor
Great point. I was going to add it to the RFC, but I saw that it is already mentioned in the second use case:
The second use case is to update the Cluster objects, or to re-do any of the steps that are necessary to add this cluster. For example, if a service account is already set up for Shipper, this command will skip that step. This makes this command idempotent, and allows it to be used for git-ops or any sort of pipeline.
Is this what you meant?
|
|
||
| .Cluster configuration file example | ||
| [source,yaml] | ||
| ---- |
This comment has been minimized.
This comment has been minimized.
icanhazbroccoli
reviewed
Oct 31, 2018
parhamdoustdar
dismissed stale reviews from
icanhazbroccoli and
kanatohodets
via
401d680
Oct 31, 2018
icanhazbroccoli
reviewed
Nov 1, 2018
kanatohodets
dismissed
icanhazbroccoli’s
stale review
via
7008623
Nov 1, 2018
kanatohodets
merged commit a62dd9a
into
master
Nov 1, 2018
parhamdoustdar
deleted the
rfcs/999-shipperctl-admin
branch
Nov 20, 2018
added a commit
that referenced
this pull request
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
isutton commentedOct 11, 2018
No description provided.