Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Introduced shipperctl admin clusters apply for setting up and updating cluster configuration #45
This pull request introduces the
Other things I did that had nothing to do with the original intent of this branch were to upgrade the version of
referenced this pull request
Nov 21, 2018
kanatohodets left a comment
I'd like to see slightly more robust validation of the cluster spec section.
For example, a
managementClusters: - name: microk8s applicationClusters: - name: microk8s
Yields errors like so:
I have a few changes that I think would help:
Overall I'm super happy about this, just want to brush up a little bit.
kanatohodets left a comment •
Tested this with an in-cluster Shipper: it worked first try! We'll have to do some work before we can convert the E2E tests to have an in-cluster Shipper (need a helm repo) but I think that would be a nice way to go eventually: use
I'm really happy with the state now: kudos on the progress output text, and also on being flexible enough to handle the range of
Edit: ok, this was a bit misleading, since microk8s runs without RBAC by default. however, after enabling RBAC and verifying that it was in force (broken cluster role binding; shipper getting 'unauthorized' API responses), everything does look good.