Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Validating webhook #60
To prevent Kubernetes to accept Shipper objects that do not conform with the schema, this PR introduces a validation webhook exposed so Shipper can review each create and update before it hits etcd.
The "webhook-controller" is started like any other of Shipper's controllers, and also responds to the stop signal that other controllers respect. It is a web-server that has an endpoint configured to ingest AdmissionReview payloads provided by Kubernetes Admission Controller, and return an AdmissionResponse with the validation's result.
A couple of assets were introduced to help setting it up (shipperctl integration is currently out of the scope of this PR):
Testing the Setup
In order to configure an existing microk8s cluster with this setup, one can use the Makefile like the following:
parhamdoustdar left a comment
Looks good to me and works as intended when I tested it. We need to do some work to integrate this into how