Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Deployment name when installing a chart #76

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@juliogreff
Copy link
Contributor

juliogreff commented Mar 19, 2019

We need the Deployment in the chart to have a unique name, meaning that
two different Releases need to generate two different Deployments.
Otherwise, we try to overwrite a previous Deployment, and that fails
with a "field is immutable" error.

Closes #72.

juliogreff added some commits Mar 19, 2019

Validate Deployment name when installing a chart
We need the Deployment in the chart to have a unique name, meaning that
two different Releases need to generate two different Deployments.
Otherwise, we try to overwrite a previous Deployment, and that fails
with a "field is immutable" error.

Closes #72.
Less verbose description of Deployment object
Logging the entire Deployment object makes the error quite hard to read.
Just logging the name of the Deployment that has an issue should be more
than enough.

@juliogreff juliogreff force-pushed the juliogreff/validate-deployment-name branch from c6fd02e to b8e5458 Mar 19, 2019

@parhamdoustdar
Copy link
Contributor

parhamdoustdar left a comment

LGTM. Congrats on your first PR!

@icanhazbroccoli
Copy link
Contributor

icanhazbroccoli left a comment

Would you mind implementing a test case for this?

installer: add test case for invalid deployment name
Adds a test case for the feature introduced by
3a52154.

@parhamdoustdar parhamdoustdar merged commit 91bc21e into master Apr 15, 2019

@parhamdoustdar parhamdoustdar deleted the juliogreff/validate-deployment-name branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.