Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes to PHP Majordomo example #89

merged 6 commits into from Jul 28, 2011


None yet
2 participants

wadim commented Jul 28, 2011

Fixed 3 critical errors and 1 conceptual error. Refactored two small pieces of code.

Wadim Grasza added some commits Jul 28, 2011

fixed array_search() used as array index in unset()
When a searched item does not exist, array_search returns false,
which, supplied as array index, is coerced to int(0) and causes
element 0 to be unset instead.
fixed worker not removed from service waiting list upon deletion
The worker should be removed from service waiting list upon deletion, just
as it is in the original C code.
removed unreachable code
This is never actually run. Exception is thrown instead in case of an interrupt.
fixed wrong number of retries
Common sense says 1 retry means "retry once", not "don't retry".

hintjens added a commit that referenced this pull request Jul 28, 2011

Merge pull request #89 from wadim/master
Fixes to PHP Majordomo example

@hintjens hintjens merged commit 05c5d79 into booksbyus:master Jul 28, 2011


hintjens commented Jul 28, 2011

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment