Fix invalid test related to dirty attributes #1312
Conversation
@therobinkim Have you considered adding more contributors to the repository? All these open PRs discourage further contribution from new people considering to use the library. |
@gajus Iiiii am guessing you didn't mean me? I am not a core contributor to this repo :D |
@therobinkim Sorry. @tgriesser Have you considered adding more contributors to the repository? All these open PRs discourage further contribution from new people considering to use the library. |
So, this was meant to test if a specific Model property ( This comes from a time when Bookshelf was based on Backbone and Backbone models do have that property. However there was code in place to exclude it (along with others, see here and here) from Bookshelf models during initialization. Since this project moved away from Backbone a few years ago this test doesn't make sense anymore. However, I think you're trying to test something else here. @vellotis can you explain what that is? |
Accidentally found an invalid test.