Skip to content

Fix invalid test related to dirty attributes - #1312

Merged
ricardograca merged 1 commit into
bookshelf:masterfrom
vellotis:fix-changed-in-test
Jan 19, 2018
Merged

Fix invalid test related to dirty attributes#1312
ricardograca merged 1 commit into
bookshelf:masterfrom
vellotis:fix-changed-in-test

Conversation

@vellotis

@vellotis vellotis commented Jul 2, 2016

Copy link
Copy Markdown
Contributor

Accidentally found an invalid test.

@gajus

gajus commented Aug 18, 2016

Copy link
Copy Markdown

@therobinkim Have you considered adding more contributors to the repository? All these open PRs discourage further contribution from new people considering to use the library.

@therobinkim

Copy link
Copy Markdown
Contributor

@gajus Iiiii am guessing you didn't mean me? I am not a core contributor to this repo :D

@gajus

gajus commented Aug 18, 2016

Copy link
Copy Markdown

@therobinkim Sorry.

@tgriesser Have you considered adding more contributors to the repository? All these open PRs discourage further contribution from new people considering to use the library.

@ricardograca

ricardograca commented Jan 5, 2018

Copy link
Copy Markdown
Member

So, this was meant to test if a specific Model property (changedAttributes) was not present when instantiating new Models.

This comes from a time when Bookshelf was based on Backbone and Backbone models do have that property. However there was code in place to exclude it (along with others, see here and here) from Bookshelf models during initialization. Since this project moved away from Backbone a few years ago this test doesn't make sense anymore.

However, I think you're trying to test something else here. @vellotis can you explain what that is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants