New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid test related to dirty attributes #1312

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
4 participants
@vellotis
Contributor

vellotis commented Jul 2, 2016

Accidentally found an invalid test.

@gajus

This comment has been minimized.

gajus commented Aug 18, 2016

@therobinkim Have you considered adding more contributors to the repository? All these open PRs discourage further contribution from new people considering to use the library.

@therobinkim

This comment has been minimized.

Contributor

therobinkim commented Aug 18, 2016

@gajus Iiiii am guessing you didn't mean me? I am not a core contributor to this repo :D

@gajus

This comment has been minimized.

gajus commented Aug 18, 2016

@therobinkim Sorry.

@tgriesser Have you considered adding more contributors to the repository? All these open PRs discourage further contribution from new people considering to use the library.

@ricardograca

This comment has been minimized.

Member

ricardograca commented Jan 5, 2018

So, this was meant to test if a specific Model property (changedAttributes) was not present when instantiating new Models.

This comes from a time when Bookshelf was based on Backbone and Backbone models do have that property. However there was code in place to exclude it (along with others, see here and here) from Bookshelf models during initialization. Since this project moved away from Backbone a few years ago this test doesn't make sense anymore.

However, I think you're trying to test something else here. @vellotis can you explain what that is?

@ricardograca ricardograca added this to To Do in Version 0.13.0 via automation Jan 16, 2018

@ricardograca ricardograca added the tests label Jan 19, 2018

@ricardograca ricardograca merged commit c051c1e into bookshelf:master Jan 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Version 0.13.0 automation moved this from To Do to Done Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment