Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure previousAttributes are parsed after eagerPair #1457

Merged

Conversation

@jbrumwell
Copy link
Contributor

@jbrumwell jbrumwell commented Nov 23, 2016

Ensure that previous attributes are properly parsed after eagerPair completes. Currently any models loaded via withRelated do not have their previous models parsed.

An unverified side effect is with _previousAttributes unparsed any call to set will cause a mismatch in parsed attributes and unparsed previous attributes resulting in values that could be equal being recorded as changed.

Should resolve #1394

@ricardograca ricardograca self-requested a review Jan 7, 2018
Copy link
Member

@ricardograca ricardograca left a comment

Looks good to me.

@ricardograca ricardograca merged commit 2f02f0b into bookshelf:master Jan 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants