Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure previousAttributes are parsed after eagerPair #1457
Conversation
ricardograca
self-requested a review
Jan 7, 2018
ricardograca
merged commit 2f02f0b
into
bookshelf:master
Jan 7, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
ricardograca
added
bug
relations
labels
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jbrumwell commentedNov 23, 2016
Ensure that previous attributes are properly parsed after eagerPair completes. Currently any models loaded via
withRelateddo not have their previous models parsed.An unverified side effect is with
_previousAttributesunparsed any call tosetwill cause a mismatch in parsed attributes and unparsed previous attributes resulting in values that could be equal being recorded as changed.Should resolve #1394