Ensure previousAttributes are parsed after eagerPair #1457
Merged
Conversation
|
Looks good to me. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ensure that previous attributes are properly parsed after eagerPair completes. Currently any models loaded via
withRelateddo not have their previous models parsed.An unverified side effect is with
_previousAttributesunparsed any call tosetwill cause a mismatch in parsed attributes and unparsed previous attributes resulting in values that could be equal being recorded as changed.Should resolve #1394