New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move .babelrc to src/ #1470

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
7 participants
@dantman
Contributor

dantman commented Dec 13, 2016

Fixes #1460

@dantman

This comment has been minimized.

Contributor

dantman commented Mar 3, 2017

@tslater

This comment has been minimized.

tslater commented Jul 19, 2017

Is there any way we could get this merged?

@dj-hedgehog

This comment has been minimized.

Member

dj-hedgehog commented Jul 19, 2017

I am not an expert with Babel.
@Playrom or anyone else Does moving it to src have any side-effect?

@Playrom

This comment has been minimized.

Contributor

Playrom commented Jul 19, 2017

no idea @dj-hedgehog

@dantman

This comment has been minimized.

Contributor

dantman commented Jul 19, 2017

No, babel files simply apply to all files in the directory they are in and sub-directories under them. So moving .babelrc to src/ only changes things so that the .babelrc doesn't apply to anything outside of src/. And from what I can see your tests and the root bookshelf.js do not use transpiled syntax.

@Playrom

This comment has been minimized.

Contributor

Playrom commented Jul 19, 2017

we are in process to discuss about the complete removal of babel from the codebase , in #1606 , please come there to discuss about any cons in the process

if we will choose to maintain babel we will merge this PR

@chamini2

This comment has been minimized.

Contributor

chamini2 commented Oct 16, 2017

What about merging and removing babel if the issue resolves to that later?

@ricardograca

This comment has been minimized.

Member

ricardograca commented Oct 16, 2017

Sounds good to me. What do you think @mrhwick ?

@mrhwick

mrhwick approved these changes Oct 16, 2017 edited

LGTM

From docs here

Babel will look for a .babelrc in the current directory of the file being transpiled. If one does not exist, it will travel up the directory tree until it finds either a .babelrc, or a package.json with a "babel": {} hash within.

image

@mrhwick mrhwick merged commit 7c772dc into bookshelf:master Oct 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment