Skip to content

Move .babelrc to src/ - #1470

Merged
mrhwick merged 1 commit into
bookshelf:masterfrom
dantman:master
Oct 16, 2017
Merged

mrhwick merged 1 commit into
bookshelf:masterfrom
dantman:master

Conversation

@dantman

@dantman dantman commented Dec 13, 2016

Copy link
Copy Markdown
Contributor

Fixes #1460

@dantman

dantman commented Mar 3, 2017

Copy link
Copy Markdown
Contributor Author

@kirrg001 @ErisDS @vellotis

@tslater

tslater commented Jul 19, 2017

Copy link
Copy Markdown

Is there any way we could get this merged?

@crunchtime-ali

crunchtime-ali commented Jul 19, 2017 •

Copy link
Copy Markdown
Member

I am not an expert with Babel.
@Playrom or anyone else Does moving it to src have any side-effect?

@Playrom

Playrom commented Jul 19, 2017

Copy link
Copy Markdown
Contributor

no idea @dj-hedgehog

@dantman

dantman commented Jul 19, 2017

Copy link
Copy Markdown
Contributor Author

No, babel files simply apply to all files in the directory they are in and sub-directories under them. So moving .babelrc to src/ only changes things so that the .babelrc doesn't apply to anything outside of src/. And from what I can see your tests and the root bookshelf.js do not use transpiled syntax.

@Playrom

Playrom commented Jul 19, 2017

Copy link
Copy Markdown
Contributor

we are in process to discuss about the complete removal of babel from the codebase , in #1606 , please come there to discuss about any cons in the process

if we will choose to maintain babel we will merge this PR

@chamini2

Copy link
Copy Markdown
Contributor

What about merging and removing babel if the issue resolves to that later?

@ricardograca

Copy link
Copy Markdown
Member

Sounds good to me. What do you think @mrhwick ?

@mrhwick mrhwick left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

From docs here

Babel will look for a .babelrc in the current directory of the file being transpiled. If one does not exist, it will travel up the directory tree until it finds either a .babelrc, or a package.json with a "babel": {} hash within.

image

@mrhwick
mrhwick merged commit 7c772dc into bookshelf:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants