New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document calling super() on initialize(). #1529

Merged
merged 3 commits into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@alsonkemp
Contributor

alsonkemp commented Mar 1, 2017

We got bitten by this bit of missing documentation: bookshelf-schema overrides Model.initialize but one of our developers followed the docs and didn't call super(). Lost about three hours debugging that...

@alsonkemp

This comment has been minimized.

Contributor

alsonkemp commented Mar 1, 2017

The build is failing because of an upgrade to knex 0.12.7. PR #1531 fixes this.

@ricardograca ricardograca added the docs label Jan 5, 2018

@ricardograca ricardograca merged commit f939fc4 into bookshelf:master Jan 5, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment