Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document calling super() on initialize(). #1529

merged 3 commits into from Jan 5, 2018


Copy link

We got bitten by this bit of missing documentation: bookshelf-schema overrides Model.initialize but one of our developers followed the docs and didn't call super(). Lost about three hours debugging that...

Copy link
Contributor Author

The build is failing because of an upgrade to knex 0.12.7. PR #1531 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants