Fix Pagination plugin #1258 #1272

[pmettraux]

based on vellotis work. see https://github.com/tgriesser/bookshelf/pull/1272/files

@vellotis I hope you don't mind I took what you did and based it on the current version of bookshelf, you deserve all the credits

[pmettraux]

Shit tests fail, my bad

[pmettraux]

Ok fixed

[vellotis]

@pmettraux Great work!

I forgot that not everybody has a long weekend. 1st of May is a holiday in wide range of European countries. I just wanted to start rebasing.

Sadly as this is still my implementation. I am not willing to merge it. @kirrg001 please review and merge the PR.

[Playrom]

ok guys, I'm here for you! what's the state of this PR?

[Playrom]

can you guys provide with a comment a PR description as in the new template PULL-REQUEST-TEMPLATE.md?

I'm willing to merge this PR but I want to read a clear description of the effects and behaviour

@vellotis @pmettraux

[ebramanti]

@pmettraux Willing to review this PR, please respond to thread before I begin

[pmettraux]

I have been working on a fork since nobody was answering. Now obviously conflicts appeared. The entire discussion is here : #1272

[Playrom]

@jadengore if you can do us the favour to review this whole fix it would be awesome 👍

[ebramanti]

@pmettraux Great, please resolve merge conflicts then I will begin my review 😄

[Playrom]

@pmettraux can you resolve conflicts? or I have to do it? :)

[pmettraux]

I do not have time these days, sorry

[Playrom]

ok I'll do it don't worry :)