Allow passing of time via options #1592
Conversation
8492393
to
555c6e0
Thanks for the PR provide the tests and I'll merge to the codebase |
fixed with #1583 , released in version 0.10.4 |
To be honest, I don't agree that the other PR fixes this issue. This PR is actually not even a fix, but rather a feature. I also think that while allowing to overwrite those fields explicitly as done in #1583 is fine, using this in place of the feature presented here is against the concept of the |
sorry I was too hurry in closing this , but because of the absence of description I was mislead, really really sorry... Can you articulate better the scope of this PR and what you mean for "passing of time"? |
The idea is that in some cases one wants to control what bookshelf thinks of as |
555c6e0
to
40ce58f
15977c3
to
72e62fb
ok so with this change you could , while setting the options for the model, set that in reality now is yesterday now I see the utility , sorry about that :) |
72e62fb
to
6fae0da
I also noticed that the other PR was merged with failing tests. I fixed the indent there. |
mmm nope the tests where ok in the other PR :\ strange that you saw failing ones |
Ok, then linting is not part of the test suite. You could consider adding it. |
2837a95
to
9bed27a
9bed27a
to
5afd426
you could open an issue and discuss about that :) in the mean time I've merged it |
Thanks for taking the time! |
thank you very much :) |
commit c001e8a Author: Giorgio Romano <Playrom@users.noreply.github.com> Date: Tue Jul 18 12:49:33 2017 +0200 Link to the bookshelf#1600 discussion in README we added a temporary link in the README to direct all developers to the discussione about the future of bookshelf.js. It will be removed in a few weeks commit 36cf1b1 Author: Michael Borst <mborst@users.noreply.github.com> Date: Tue Jul 18 12:01:47 2017 +0200 Allow passing of time via options (bookshelf#1592) * Fix indent in timestamp method * Allow passing of time via options commit cd9e9d2 Author: kirrg001 <katharina.irrgang@googlemail.com> Date: Mon Jul 17 17:01:05 2017 +0200 Release 0.10.4
* https://github.com/bookshelf/bookshelf: (43 commits) Fixed random test failure in test/integration/model.js Update .npmignore to exclude non-prod files Fix bookshelf#1662: move appropriate files into .github directory chore(package): update babel-eslint to version 8.0.1 Add js formatting to "How do I debug?" at README Revert "Update dependencies to enable Greenkeeper🌴 (bookshelf#1616)" Update dependencies to enable Greenkeeper🌴 (bookshelf#1616) small registry plugin refactoring for easier read Build Project before testing in "npm test" script Update README.md (bookshelf#1537) New implementation for the setting of timestamps columns values Update CONTRIBUTING.md due to changes in MySQL 5.7 (bookshelf#1610) use OracleDB tests only when oracledb is installed (bookshelf#1609) added morphValues for morphTo relation (bookshelf#1326) Rename ISSUE-TEMPLATE.md to ISSUE_TEMPLATE.md Rename PR-TEMPLATE.md to PULL_REQUEST_TEMPLATE.md Revision to the contributing guidelines (bookshelf#1601) npm install knex@0.13 in the README (bookshelf#1604) Link to the bookshelf#1600 discussion in README Allow passing of time via options (bookshelf#1592) ...
No description provided.