Allow passing of time via options

[mborst]

No description provided.

[Playrom]

Thanks for the PR

provide the tests and I'll merge to the codebase 👍

[Playrom]

fixed with #1583 , released in version 0.10.4

[mborst]

To be honest, I don't agree that the other PR fixes this issue. This PR is actually not even a fix, but rather a feature. I also think that while allowing to overwrite those fields explicitly as done in #1583 is fine, using this in place of the feature presented here is against the concept of the hasTimestamp feature, which handles the selection of the proper field to touch (createdAt vs updatedAt). Now, the client code always has to figure out if the operation will be an insert or an update, which is unnecessary in the solution presented here. WDYT?

[Playrom]

sorry I was too hurry in closing this , but because of the absence of description I was mislead, really really sorry...

Can you articulate better the scope of this PR and what you mean for "passing of time"?

[mborst]

The idea is that in some cases one wants to control what bookshelf thinks of as now, e.g. when you write state changes to two different places, like the db and a log. Now that #1583 is merged, you could manually do that, but that would not have the same convenience as using hasTimestamp, which handles updating the correct timestamp, i.e. updated_at on update, created_at on insert. IMHO, the feature proposed here is the sweet spot.

[Playrom]

ok so with this change you could , while setting the options for the model, set that in reality now is yesterday

now I see the utility , sorry about that :)

[mborst]

I also noticed that the other PR was merged with failing tests. I fixed the indent there.

[Playrom]

mmm nope the tests where ok in the other PR :\ strange that you saw failing ones

[mborst]

Ok, then linting is not part of the test suite. You could consider adding it.

[Playrom]

you could open an issue and discuss about that :)

in the mean time I've merged it

[mborst]

Thanks for taking the time!
I still can't quite figure out what happened with the other merge, because from a quick glance at the package.json it seems like the linting is run in the CI. But e367622 fixes wrong indentation that could be merged into master... will investigate when I find the time.

[Playrom]

thank you very much :)