Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add withSchema support #1638

Merged
merged 1 commit into from Feb 18, 2018
Merged

add withSchema support #1638

merged 1 commit into from Feb 18, 2018

Conversation

@rendongsc
Copy link

@rendongsc rendongsc commented Sep 1, 2017

add withSchema support

Our system has multiple modules, each module is a separate database schema, we hope that through an single knex instance of the operation of multiple schmea.
knexjs-withSchema

unknown
@ricardograca
Copy link
Member

@ricardograca ricardograca commented Sep 1, 2017

Would be helpful if you filled out the issue template so we can get some context about this proposal.

@maxkoryukov
Copy link

@maxkoryukov maxkoryukov commented Sep 9, 2017

@rendongsc I use just a few features, but in my code, I utilize withSchema and I haven't any problem. All work just fine

@ricardograca ricardograca added this to To Do in Version 0.13.0 via automation Jan 9, 2018
Copy link
Member

@ricardograca ricardograca left a comment

I'll add the tests myself in a subsequent pull request.

@ricardograca ricardograca merged commit 54e45c1 into bookshelf:master Feb 18, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Version 0.13.0 automation moved this from To Do to Done Feb 18, 2018
weswigham added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Mar 11, 2019
PR where the option was added:
bookshelf/bookshelf#1638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants