Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upadd withSchema support #1638
+1
−0
Conversation
This comment has been minimized.
This comment has been minimized.
|
Would be helpful if you filled out the issue template so we can get some context about this proposal. |
ricardograca
added
the
More information required
label
Sep 1, 2017
This comment has been minimized.
This comment has been minimized.
maxkoryukov
commented
Sep 9, 2017
|
@rendongsc I use just a few features, but in my code, I utilize |
ricardograca
added this to To Do
in Version 0.13.0
via automation
Jan 9, 2018
ricardograca
added
feature request
weak/no tests
and removed
More information required
labels
Jan 26, 2018
ricardograca
approved these changes
Feb 18, 2018
I'll add the tests myself in a subsequent pull request.
ricardograca
merged commit 54e45c1
into
bookshelf:master
Feb 18, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Version 0.13.0
automation
moved this from To Do
to Done
Feb 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rendongsc commentedSep 1, 2017
•
edited
add withSchema support
Our system has multiple modules, each module is a separate database schema, we hope that through an single knex instance of the operation of multiple schmea.
knexjs-withSchema