Skip to content

Update .npmignore to exclude non-prod files - #1679

Merged
ricardograca merged 1 commit into
bookshelf:masterfrom
osher:patch-1
Nov 2, 2017
Merged

Update .npmignore to exclude non-prod files#1679
ricardograca merged 1 commit into
bookshelf:masterfrom
osher:patch-1

Conversation

@osher

@osher osher commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

Update .npmignore to exclude non-prod files

Introduction

See #1678

Motivation

This should reduce package size in about a half...

Proposed solution

exclude files not required for production installations using .gitignore
(which was present, only did a partial job - probably just was not updated as the project grew 😉)

Current PR Issues

none

Alternatives considered

none

src, scripts, .babelrc, .npmignore
@ricardograca

Copy link
Copy Markdown
Member

This seems like an even better fix for #1460 than #1470. Thanks!

@ricardograca
ricardograca merged commit 2f7be49 into bookshelf:master Nov 2, 2017
@osher
osher deleted the patch-1 branch November 15, 2017 17:22
@leebickmtu

Copy link
Copy Markdown

Seems to be causing an issue with npm installs #1691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants