New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .npmignore to exclude non-prod files #1679

Merged
merged 1 commit into from Nov 2, 2017

Conversation

Projects
None yet
3 participants
@osher
Contributor

osher commented Nov 2, 2017

Update .npmignore to exclude non-prod files

Introduction

See #1678

Motivation

This should reduce package size in about a half...

Proposed solution

exclude files not required for production installations using .gitignore
(which was present, only did a partial job - probably just was not updated as the project grew 馃槈)

Current PR Issues

none

Alternatives considered

none

Update .npmignore to exclude non-prod files
src, scripts, .babelrc, .npmignore
@ricardograca

This comment has been minimized.

Member

ricardograca commented Nov 2, 2017

This seems like an even better fix for #1460 than #1470. Thanks!

@ricardograca ricardograca merged commit 2f7be49 into bookshelf:master Nov 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@osher osher deleted the osher:patch-1 branch Nov 15, 2017

@leebickmtu

This comment has been minimized.

leebickmtu commented Nov 15, 2017

Seems to be causing an issue with npm installs #1691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment