New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of some events #1723

Merged
merged 6 commits into from Jan 3, 2018

Conversation

Projects
None yet
1 participant
@ricardograca
Member

ricardograca commented Jan 2, 2018

Introduction

Documentation for the second argument (called attrs up until now) of some events is completely wrong. This fixes it but those second arguments should be revised anyway to discuss if they make sense in their current form.

This change builds on the previous PR linked above, but goes a bit further so that linked PR is no longer needed.

Fixes #1015, closes #1657.

Current PR Issues

Doesn't fix the issue of useless return values for some of these arguments.

@ricardograca

This comment has been minimized.

Member

ricardograca commented Jan 3, 2018

Tests are failing on Node 8 due to babel for some reason. Even replacing babel-preset-es2015 with babel-preset-env doesn't solve the problem. It just produces a different error. The update to use Ubuntu 16.04 on Travis seems to cause no issues, so I'll leave that in.

@ricardograca ricardograca merged commit 6a66abb into master Jan 3, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@ricardograca ricardograca deleted the rg-fix-docs branch Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment