Fix documentation of some events #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardograca
force-pushed
the
rg-fix-docs
branch
from
b4c3a8b to
d31a9ed
Compare
Member
Author
|
Tests are failing on Node 8 due to babel for some reason. Even replacing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Documentation for the second argument (called
attrsup until now) of some events is completely wrong. This fixes it but those second arguments should be revised anyway to discuss if they make sense in their current form.This change builds on the previous PR linked above, but goes a bit further so that linked PR is no longer needed.
Fixes #1015, closes #1657.
Current PR Issues
Doesn't fix the issue of useless return values for some of these arguments.