Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove OracleDB tests #1744
Remove all OracleDB related tests and associated code.
The tests for OracleDB are an endless cause of problems and build errors that have nothing to do with Bookshelf. To make matters worse, the entire test suite must run on the slower
This change is also in line with the ideas expressed in #1600 and #1661 of removing all database adapter tests and leave that concern to the query builder being used (Knex). Since Knex already tests against several databases, including OracleDB, there shouldn't be any reason to duplicate those tests in Bookshelf.
This change simply removes all OracleDB tests, which shouldn't be a problem anyway, since we don't have any database specific code. Since removing tests for all other databases is going to require more work, it's best to start with the database that is easier to remove and that is causing more problems.
Removing OracleDB tests already made the TravisCI build much faster which is valuable in terms of development and quality of life for the developers.
Current PR Issues
Doesn't remove all database adapter tests.
Finding a maintainer for OracleDB support within Bookshelf, but that would be short lived anyway, since the plan is to move away from tests with actual databases and instead test the behavior of Bookshelf alone.
Separating OracleDB tests into a separate build matrix that is allowed to fail, but that would require a little bit of work to adapt the test suite, and again is against the objectives already mentioned.