Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Remove all OracleDB related tests and associated code.
Motivation
The tests for OracleDB are an endless cause of problems and build errors that have nothing to do with Bookshelf. To make matters worse, the entire test suite must run on the slower
sudo: required
Travis infrastructure which usually entails very long wait times before the build even starts (it can take hours), as well as taking double the time to run the test suite itself due to the extra OracleDB installation steps.This change is also in line with the ideas expressed in #1600 and #1661 of removing all database adapter tests and leave that concern to the query builder being used (Knex). Since Knex already tests against several databases, including OracleDB, there shouldn't be any reason to duplicate those tests in Bookshelf.
Proposed solution
This change simply removes all OracleDB tests, which shouldn't be a problem anyway, since we don't have any database specific code. Since removing tests for all other databases is going to require more work, it's best to start with the database that is easier to remove and that is causing more problems.
Removing OracleDB tests already made the TravisCI build much faster which is valuable in terms of development and quality of life for the developers.
Current PR Issues
Doesn't remove all database adapter tests.
Alternatives considered
Finding a maintainer for OracleDB support within Bookshelf, but that would be short lived anyway, since the plan is to move away from tests with actual databases and instead test the behavior of Bookshelf alone.
Separating OracleDB tests into a separate build matrix that is allowed to fail, but that would require a little bit of work to adapt the test suite, and again is against the objectives already mentioned.