Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OracleDB tests #1744

merged 5 commits into from Jan 16, 2018

Remove OracleDB tests #1744

merged 5 commits into from Jan 16, 2018


Copy link

@ricardograca ricardograca commented Jan 14, 2018


Remove all OracleDB related tests and associated code.


The tests for OracleDB are an endless cause of problems and build errors that have nothing to do with Bookshelf. To make matters worse, the entire test suite must run on the slower sudo: required Travis infrastructure which usually entails very long wait times before the build even starts (it can take hours), as well as taking double the time to run the test suite itself due to the extra OracleDB installation steps.

This change is also in line with the ideas expressed in #1600 and #1661 of removing all database adapter tests and leave that concern to the query builder being used (Knex). Since Knex already tests against several databases, including OracleDB, there shouldn't be any reason to duplicate those tests in Bookshelf.

Proposed solution

This change simply removes all OracleDB tests, which shouldn't be a problem anyway, since we don't have any database specific code. Since removing tests for all other databases is going to require more work, it's best to start with the database that is easier to remove and that is causing more problems.

Removing OracleDB tests already made the TravisCI build much faster which is valuable in terms of development and quality of life for the developers.

Current PR Issues

Doesn't remove all database adapter tests.

Alternatives considered

Finding a maintainer for OracleDB support within Bookshelf, but that would be short lived anyway, since the plan is to move away from tests with actual databases and instead test the behavior of Bookshelf alone.

Separating OracleDB tests into a separate build matrix that is allowed to fail, but that would require a little bit of work to adapt the test suite, and again is against the objectives already mentioned.

@ricardograca ricardograca added this to To Do in Version 0.13.0 via automation Jan 14, 2018
@ricardograca ricardograca moved this from To Do to In Progress in Version 0.13.0 Jan 14, 2018
@ricardograca ricardograca merged commit f08d2a5 into master Jan 16, 2018
Version 0.13.0 automation moved this from In Progress to Done Jan 16, 2018
@ricardograca ricardograca deleted the rg-remove-oracle branch January 16, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No open projects

Successfully merging this pull request may close these issues.

None yet

1 participant