Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on parse-and-format tutorial #1748

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Fix typo on parse-and-format tutorial #1748

merged 1 commit into from
Jan 19, 2018

Conversation

vieiralucas
Copy link
Contributor

@vieiralucas vieiralucas commented Jan 19, 2018 •
edited
Loading

Unless I am missing something it looks like response should be attributes

Thanks for this awesome library btw ❤️

ricardograca
ricardograca approved these changes Jan 19, 2018
View reviewed changes
Copy link
Member

@ricardograca ricardograca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should 👍

@ricardograca ricardograca merged commit b2dadf2 into bookshelf:master Jan 19, 2018
@vieiralucas vieiralucas deleted the patch-1 branch January 19, 2018 19:02
@ricardograca ricardograca mentioned this pull request Mar 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardograca ricardograca ricardograca approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vieiralucas @ricardograca