New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few general improvements to the test suite #1753

Merged
merged 14 commits into from Feb 3, 2018

Conversation

Projects
1 participant
@ricardograca
Member

ricardograca commented Feb 2, 2018

Introduction

This updates the test suite with a few small improvements and bug fixes that should help improve stability.

Motivation

Noticed a couple of tests that weren't returning Promises properly, so decided to go over all of them. Turns out there were quite a few more in the same situation. This explains why the test suite would fail sometimes and run perfectly fine next.

Since I was already there also applied a bit of formatting to some parts that were very different from the rest of the files, fixed or removed commented out test cases and removed unused code.

Current PR Issues

This doesn't make the test suite much better. There are still a lot of cases of huge tests that try to do too much. These should be split into smaller ones eventually. There are also tests that don't actually test the thing they claim to be testing, but test for side-effects instead.

@ricardograca ricardograca added the tests label Feb 2, 2018

@ricardograca ricardograca added this to To Do in Version 0.13.0 via automation Feb 2, 2018

@ricardograca ricardograca merged commit 20403f9 into master Feb 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Version 0.13.0 automation moved this from To Do to Done Feb 3, 2018

@ricardograca ricardograca deleted the rg-improve-tests branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment