Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upA few general improvements to the test suite #1753
Conversation
ricardograca
added some commits
Jan 21, 2018
ricardograca
added
the
tests
label
Feb 2, 2018
ricardograca
added this to To Do
in Version 0.13.0
via automation
Feb 2, 2018
ricardograca
merged commit 20403f9
into
master
Feb 3, 2018
Version 0.13.0
automation
moved this from To Do
to Done
Feb 3, 2018
ricardograca
deleted the
rg-improve-tests
branch
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ricardograca commentedFeb 2, 2018
Introduction
This updates the test suite with a few small improvements and bug fixes that should help improve stability.
Motivation
Noticed a couple of tests that weren't returning Promises properly, so decided to go over all of them. Turns out there were quite a few more in the same situation. This explains why the test suite would fail sometimes and run perfectly fine next.
Since I was already there also applied a bit of formatting to some parts that were very different from the rest of the files, fixed or removed commented out test cases and removed unused code.
Current PR Issues
This doesn't make the test suite much better. There are still a lot of cases of huge tests that try to do too much. These should be split into smaller ones eventually. There are also tests that don't actually test the thing they claim to be testing, but test for side-effects instead.