Set model.id if attributes contain a parsed version of idAttribute #1760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This ensures that
Model#id
is set correctly even if the model has a custom parse method that mutates attribute keys.Motivation
This is a followup to the previous PR that needed some changes but its author didn't respond.
Proposed solution
This is almost identical to the previous PR, except that it doesn't store the parsed id attribute when extending the model but instead parses it when it's actually needed. This ensures that the parsed
idAttribute
is always correct.This PR also doesn't include the exception when not all relations can be retrieved since it wasn't clear what the purpose of that code was.
Closes #1082.