Events are triggered sequentially when the handlers execute async code #1768
closes #1765 - `triggerThen` was running in parallel before - event handlers were executed at the same time - that means you can't rely on an operation (or a change) which a previous handler executed - use `mapSeries` instead - added a test
kirrg001 added a commit to kirrg001/Ghost that referenced this pull request
Mar 27, 2018
- i discovered two bookshelf bugs on 0.10.3 - bookshelf/bookshelf#1769 - bookshelf/bookshelf#1768 - we are currently locked to 0.10.3, because we saw a connection problem when updating to the latest knex+bookshelf - using a tarball can trouble when installing deps - we saw this in the past - e.g. you have bookshelf already installed - now you switch to a tarball - neither yarn, nor npm are able to replace the dep - require bookshelf-0.10.3
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.