Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added test that `parentId` is not undefined when using `fetchAll` with relations #1769
So yeah on 0.10.3 this test fails when i remove my code adaptions.
We could still merge test improvements to assert that
This calls e.g.
Could be. I never delved too deep into the relations code. Are you going to investigate? It's quite possible that your fix is better than the already merged one, in which case it should be replaced. The current test suite has a test in place for #629.
added a commit
this pull request
Feb 22, 2018
I have not investigated much, but my gut feeling tells me to keep the fix in master as is.
I'll just update my PR to check that the relational data is not undefined.