Only request returning attribute if client supports returning

[larryprice]

• Related Issues: tgriesser/knex#1660
• Previous PRs: tgriesser/knex#2471

Introduction

knex 0.14.4 has been updated such that a warning is logged when using the returning attribute in a SQL dialect that does not support it. bookshelf always requests a returning attribute during an insert, which causes a flood of unwarranted warning messages whenever sqlite3 is used, and there is no way to tell bookshelf not to specify returning.

Motivation

When running my tests, I see warning messages like this flood my logs every time I call an insert:

console.log node_modules/knex/lib/helpers.js:90
  Knex:warning - .returning() is not supported by sqlite3 and will not have any effect.
console.log node_modules/knex/lib/helpers.js:90
  Knex:warning - .returning() is not supported by sqlite3 and will not have any effect.
console.log node_modules/knex/lib/helpers.js:90
  Knex:warning - .returning() is not supported by sqlite3 and will not have any effect.

Proposed solution

My solution is to check if the current client supports returning and request the idAttribute if and only if the support is available.

Current PR Issues

N/A

Alternatives considered

Also considered updating the client within knex to be able to do this logic. However, due to the fact that this change was implemented on the knex side, I have to assume that this is intended behavior.

[ricardograca]

Thanks for this, but the test suite must pass before this gets merged.

[larryprice]

@ricardograca Thanks, I've updated the PR to pass the tests.

[ricardograca]

This is something that probably should be abstracted away in knex, but for now we'll handle it.

[sachincloudnaut]

Hi, I am struggling with returning keyword as AWS Redshift does not support it. Please let me know how should i configure in Bookshelf.js. I am using "bookshelf": "^1.0.0" , "knex": "^0.19.4" and "pg": "^7.12.1"
Select works but Insert, Update does not work due to Returning keyword being added at the end of query.

Please guide

[ricardograca]

AWS Redshift is not in the list of clients that support RETURNING, so I have no idea why that is causing any issues. Can you provide more details?

[fl0w]

The problem is that that Redshift is pg compliant, and so I'm assuming @sachincloudnaut uses pg driver, which do support it - while Redshift does not. So Bookshelf thinks this is fine, Redshift disagrees.

[ricardograca]

Let's continue the discussion in #2024.