Make require: true the default for deleting models#1779
Merged
Conversation
ricardograca
changed the title
ricardograca
changed the title
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Change
Model.destroy()so that therequire: trueoption is the default.Motivation
This makes
.destroy()behave the same way assave()and also matches what the documentation already says.Current PR Issues
This is a breaking change so it must be clearly marked as such and there should be some kind of document to help users with the transition to this new behavior.
Alternatives considered
Not addressing this issue right now, but that would just be delaying the inevitable. It's better to do it in a
0.xrelease where some breakage is expected.