Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chai #1780

Merged
merged 2 commits into from Mar 4, 2018
Merged

Update chai #1780

merged 2 commits into from Mar 4, 2018

Conversation

@ricardograca
Copy link
Member

@ricardograca ricardograca commented Mar 4, 2018

Introduction

Update chai to a more recent version. This required a small change in one of the test helpers.

Motivation

David was showing it as outdated with a red semaphore and everything which made me sad 馃槩

Proposed solution

Unfortunately we can't update to the more recent version (4.1.2) due to a bug in that version that causes the wrong error to be reported when an expect() fails.

The countModels() test helper method had to be changed to do type coercion from string to number. This wasn't a problem before because chai did this coercion itself in the within, above, least, below, most, increase and decrease methods, but that changed with version 4.0.0.

Current PR Issues

Not the most recent version, but close enough.

ricardograca added 2 commits Mar 4, 2018
- Note that there's currently a bug with the 4.1.x versions where a
failure in an expect will leak a variable to the global scope, causing
mocha to report that leak instead of the actual failure.
@ricardograca ricardograca added this to To Do in Version 0.13.0 via automation Mar 4, 2018
@ricardograca ricardograca changed the title Rg update chai Update chai Mar 4, 2018
@ricardograca ricardograca moved this from To Do to In Progress in Version 0.13.0 Mar 4, 2018
@ricardograca ricardograca merged commit bc7d021 into master Mar 4, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Version 0.13.0 automation moved this from In Progress to Done Mar 4, 2018
@ricardograca ricardograca deleted the rg-update-chai branch Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant