Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect docs for collection:fetching event #1831

Merged
merged 1 commit into from Apr 27, 2018
Merged

Conversation

@ricardograca
Copy link
Member

@ricardograca ricardograca commented Apr 27, 2018

Introduction

This fixes the incorrect documentation for the collection:fetching event.

Proposed solution

The first argument is actually an empty collection since it hasn't been fetched yet.

This also adds some other clarifications around the second argument for both the collection:fetching and collection:fetched events.

Fixes #1818.

@ricardograca ricardograca added this to To Do in Version 0.14.0 via automation Apr 27, 2018
@ricardograca ricardograca merged commit b9670c1 into master Apr 27, 2018
2 checks passed
Version 0.14.0 automation moved this from To Do to Done Apr 27, 2018
@ricardograca ricardograca deleted the rg-fix-docs branch Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

1 participant