New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Babel with Node 4 compatible JavaScript #1835

Merged
merged 13 commits into from May 3, 2018

Conversation

Projects
1 participant
@ricardograca
Copy link
Member

ricardograca commented May 2, 2018

Introduction

This removes babel and uses JavaScript compatible with Node version 4 and newer.

Motivation

The related issue #1606 provides more info, but it all boils down to increased maintainability.

Proposed solution

All Babel related code is removed and only JavaScript compatible with Node 4 is used.

Even though this version of Node supports the class syntax, some classes had to be converted to plain functions because they were producing strange errors that were hard to debug, probably related with #756.

Where possible some optimizations were implemented, and the usage of lodash is also reduced in favor of native alternatives that perform better.

Also includes the changes proposed in #1633.

Closes #1633, fixes #1717, fixes #1606.

Current PR Issues

This wasn't extensively tested outside of making sure the test suite runs correctly, but the code coverage is pretty good, so there shouldn't be any major issues with the conversion.

@ricardograca ricardograca added the change label May 2, 2018

@ricardograca ricardograca added this to To Do in Version 0.14.0 via automation May 2, 2018

@ricardograca ricardograca moved this from To Do to In progress in Version 0.14.0 May 2, 2018

@ricardograca ricardograca merged commit e820638 into master May 3, 2018

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

Version 0.14.0 automation moved this from In progress to Done May 3, 2018

@ricardograca ricardograca deleted the rg-remove-babel branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment