Fix eager loading of relations when using parse/format - #1838
Merged
Conversation
- Eager loading related models is failing when the parent model has a custom id attribute and a parse/format method that mutates it.
- The failure was when Eager loading related models is failing when the parent model had a custom id attribute and a parse/format method that mutated it.
|
@ricardograca thanks!!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
This fixes eager loading of related models when the parent model had a custom id attribute and a parse/format method that mutated it.
Motivation
For more info check the linked issue.
Proposed solution
This just runs the
parentIdAttributethrough that model'sparsemethod in order to get the parsed key that is needed for pairing the eager fetched models with their parents.Fixes #1502.
Alternatives considered
A better approach would probably be to delay the parsing of model attributes until the very last moment before models are delivered to the user, but that would require a more extensive refactoring of the whole
parse/formatfunctionality that is better suited for a separate task later on.