New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check for adding withRelated inside events #1853

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
1 participant
@ricardograca
Copy link
Member

ricardograca commented Jun 1, 2018

Introduction

Adds a test to check that it is possible to modify the value of withRelated inside a fetching event handler.

Motivation

The issue linked above doesn't seem to be valid anymore, but it's a good idea to add a test to check for the correct behavior it describes anyway, since it seems to have been a problem at some point.

Closes #1445.

@ricardograca ricardograca added the tests label Jun 1, 2018

@ricardograca ricardograca added this to To Do in Version 0.14.0 via automation Jun 1, 2018

@ricardograca ricardograca moved this from To Do to In progress in Version 0.14.0 Jun 1, 2018

@ricardograca ricardograca merged commit 2071146 into master Jun 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Version 0.14.0 automation moved this from In progress to Done Jun 1, 2018

@ricardograca ricardograca deleted the rg-events-withrelated branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment