Create previousAttributes using a deep clone of attributes#1876
Merged
ricardograca merged 1 commit intoNov 4, 2018
Conversation
ricardograca
requested changes
Jul 9, 2018
ricardograca
left a comment
ricardograca
left a comment
Member
There was a problem hiding this comment.
Everything looks good except for the test description which seems a bit misleading and could lead to confusion further down the road.
| }); | ||
| }); | ||
|
|
||
| it('can update attributes without affecting _previousAttributes', function() { |
Member
There was a problem hiding this comment.
I'm not sure this description fits with what is actually being tested here. It should be the opposite since previousAttributes will now detect changes to nested objects.
Member
|
I'm going to merge this as is and then change the description of the test in another PR. |
Member
|
Renamed in fc66733. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Altered
Model._resetto use a deep clone so that changes toModel.attributesdon't affectModel._previousAttributes.Motivation
Problem is detailed in #1875.
Proposed solution
Use
_.cloneDeep. Fixes #1875.Current PR Issues
None
Alternatives considered
None