use prettier to format all of js,json files

[chentsulin]

• Related Issues: Add more style rules to eslint config file #1729

Introduction

Use prettier and husky + lint-staged precommit hook to auto format all of js, json files

Proposed solution

Follow @tgriesser's .prettierrc config and npm scripts in knex/knex#2697

[ricardograca]

Nice work. I'll check it out ASAP and report back.

[crunchtime-ali]

ok, thank you for clarifying.
Besides that the PR LGTM.

[ricardograca]

Finally, if you could change bracketSpacing to false I think it would help to cut down the number of lines touched by this PR.

Still, I'm not entirely convinced I prefer this over Standard.js, so can you explain its advantages and what the development workflow looks like with this? Do I have to install any IDE plugins? Run a script before committing?

[ricardograca]

I'd prefer if this was set to "none". Also, can you set semi: false?

[ricardograca]

Wow. I really hate how the function arguments are split into individual lines like this. Makes no sense for such a small number of arguments. Is it possible to avoid this?

[ricardograca]

This is weird. Splitting a single line fat arrow function into multiple lines makes its intention a bit ambiguous: e.g. was it supposed to be returning something or was it supposed to return undefined? Did the author made a mistake?

[ricardograca]

This is definitely super weird 😕 Why is the options.patch in a single line by itself? Is there like a 80 column max line length limit or something?

[crunchtime-ali]

Yes, it wraps per default at 80 columns however you can set it via printWidth to a more reasonable amount. I suggest 120 columns. This should fix most of your aforementioned problems. How many columns do you suggest @ricardograca

[ricardograca]

👍 120 sounds good to me as well. 80 is definitely too narrow.

[crunchtime-ali]

@chentsulin Can you please set printWidth: 120 and run prettier on the codebase again?

[chentsulin]

Added those config:

"bracketSpacing": false,
"semi": false,
"printWidth": 120

[ricardograca]

@chentsulin Can you address the last remaining comment above? I can do that after merging this, but I'd like to avoid several multi-thousand lines PRs if possible.

[chentsulin]

@ricardograca

I set trailingComma to none, semi to true, those changes save ~4000 line changes.

Before:

After

[ricardograca]

Many thanks!