change hasOne's doc - #1890
Merged
Merged
Conversation
ricardograca
approved these changes
Sep 13, 2018
ricardograca
left a comment
ricardograca
left a comment
Member
There was a problem hiding this comment.
Good catch. I'll merge this as is, but if you could also update the hasMany document which has a similar mistake that would be great. I guess these were just copied over from belongsTo.
Contributor
Author
|
I made that change in my fork. But It seems I messed things up: that commitment was combined with the other pull request which I later closed. and I don't know how to make that change in this one.... |
Member
|
You can push more commits to the |
Contributor
Author
|
done:) |
Member
|
Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
a possible typo in model.hasOne's doc