New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change hasOne's doc #1890

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
2 participants
@eerenyuan
Copy link
Contributor

eerenyuan commented Sep 13, 2018

Introduction

a possible typo in model.hasOne's doc

@ricardograca
Copy link
Member

ricardograca left a comment

Good catch. I'll merge this as is, but if you could also update the hasMany document which has a similar mistake that would be great. I guess these were just copied over from belongsTo.

@ricardograca ricardograca added the docs label Sep 13, 2018

@ricardograca ricardograca added this to To Do in Version 0.14.0 via automation Sep 13, 2018

@eerenyuan

This comment has been minimized.

Copy link
Contributor

eerenyuan commented Sep 13, 2018

I made that change in my fork. But It seems I messed things up: that commitment was combined with the other pull request which I later closed. and I don't know how to make that change in this one....

@ricardograca

This comment has been minimized.

Copy link
Member

ricardograca commented Sep 13, 2018

You can push more commits to the eerenyuan:patch-1 branch to update this PR.

@eerenyuan

This comment has been minimized.

Copy link
Contributor

eerenyuan commented Sep 13, 2018

done:)

@ricardograca ricardograca merged commit b6abda9 into bookshelf:master Sep 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Version 0.14.0 automation moved this from To Do to Done Sep 13, 2018

@ricardograca

This comment has been minimized.

Copy link
Member

ricardograca commented Sep 13, 2018

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment