pagination-plugin and fetch options on count fix

[throrin19]

• Related Issues: fetchPage and bookshelf-paranoia #1913

Introduction

Make the pagination plugin fully compatible with others bookshelf plugins

Motivation

In my project, I use the plugin bookshelf-paranoia to use the soft delete feature. I have a problem with pagination.

If I want to show soft deleted items using pagination, the fetchPaginate function return correctly the models but don't return correct count.

After resarch, it appears the count part don't use passed fetch options except the transacting parameter.

Proposed solution

I propose to use others fetch options on count part omit all default fetch params (withRelated, ...) to avoid problems

[ricardograca]

This looks good, but it needs tests to verify the correct behavior of the fix and to ensure it doesn't get re-introduced in the future.

[throrin19]

I hope I make correct tests, I try if the count lost standard options and keep custom options

[ricardograca]

Nice work! I'll review this properly soon.

[ricardograca]

Looks good to me and all tests pass.

[throrin19]

Great !! Have you a release date for this PR integration in bookshelf ? I realy need this in my current development

[ricardograca]

I will most likely make it to the next version (0.14.0) which will be released soon.