Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass proper context #1926

Merged
merged 1 commit into from Dec 17, 2018
Merged

Pass proper context #1926

merged 1 commit into from Dec 17, 2018

Conversation

@jbrumwell
Copy link
Contributor

@jbrumwell jbrumwell commented Dec 13, 2018

In version 0.16 of knex, not passing the knex context results in this.client.transaction being undefined.

In version 0.16 of knex, not passing the knex context results in `this.client.transaction` being undefined.
@ricardograca
Copy link
Member

@ricardograca ricardograca commented Dec 13, 2018

Thanks. The current version of Bookshelf is not fully compatible with Knex 0.15.0+ yet, but that will be added in the next version.

@ricardograca ricardograca added this to To do in Version 1.0.0 via automation Dec 13, 2018
@ricardograca ricardograca merged commit 68e8537 into bookshelf:master Dec 17, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Version 1.0.0 automation moved this from To do to Done Dec 17, 2018
@ricardograca
Copy link
Member

@ricardograca ricardograca commented Dec 17, 2018

This will be released in a patch update to Bookshelf soon.

@ricardograca
Copy link
Member

@ricardograca ricardograca commented Dec 17, 2018

Released in 0.14.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 1.0.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants