Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using groupBy with table qualifier #1928

Merged
merged 1 commit into from Dec 17, 2018

Conversation

@ricardograca
Copy link
Member

@ricardograca ricardograca commented Dec 17, 2018

Introduction

This fixes a bug that creates an incorrect query when using groupBy with the pagination plugin. The issue is only in the row count part of fetchPage.

Motivation

Fixes #1925.

Proposed solution

The solution is taken straight out of the linked issue. All tests pass and a new one was added to ensure this isn't re-introduced again in the future.

@ricardograca ricardograca merged commit 62371cc into master Dec 17, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ricardograca ricardograca deleted the rg-fix-pagination-groupby branch Dec 17, 2018
@ricardograca
Copy link
Member Author

@ricardograca ricardograca commented Dec 17, 2018

Fix released in 0.14.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant