Fix missing attributes in some events #1934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Fixes an issue that prevented all of the attributes that are going to be inserted or updated to be present in the second argument to the event listener of both the
creating
andupdating
events.Motivation
Fixes #1433.
Proposed solution
This simply moves the logic that selects which attributes are going to be saved a bit further up and uses that as the argument to the event handlers, instead of always passing the
attrs
object.Also adds another test to verify that
save()
will use both the attributes passed to it as well as any others that were already set on the model.