Fix missing attributes in some events#1934
Merged
ricardograca merged 4 commits intomasterfrom Dec 25, 2018
Merged
Conversation
- Fixes an issue where only the attributes passed to the save() call would be persent in the second argument of event listeners.
6utt3rfly
added a commit
to betastreet/bookshelf-modelbase-plus
that referenced
this pull request
Apr 29, 2019
6utt3rfly
added a commit
to betastreet/bookshelf-modelbase-plus
that referenced
this pull request
Apr 29, 2019
6utt3rfly
added a commit
to betastreet/bookshelf-prefixed-ordered-uuid
that referenced
this pull request
Apr 29, 2019
Member
Author
|
This was released in version 0.15.0. |
This was referenced Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Fixes an issue that prevented all of the attributes that are going to be inserted or updated to be present in the second argument to the event listener of both the
creatingandupdatingevents.Motivation
Fixes #1433.
Proposed solution
This simply moves the logic that selects which attributes are going to be saved a bit further up and uses that as the argument to the event handlers, instead of always passing the
attrsobject.Also adds another test to verify that
save()will use both the attributes passed to it as well as any others that were already set on the model.