Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1940

Merged
merged 2 commits into from Jan 17, 2019
Merged

Update README.md #1940

merged 2 commits into from Jan 17, 2019

Conversation

@rbrtmrtn
Copy link
Contributor

@rbrtmrtn rbrtmrtn commented Jan 15, 2019

Hello! This PR has a few suggested edits to the README, mostly to clean up some typographic and style matters. Nothing too major :) Thanks for all your work on this project and hope this is helpful!

Minor edits for style and consistency
Copy link
Member

@ricardograca ricardograca left a comment

Everything looks pretty good except for the little issue I mentioned. As soon as you fix that this will be merged.

README.md Outdated Show resolved Hide resolved
@ricardograca ricardograca added this to To do in Version 1.0.0 via automation Jan 15, 2019
@ricardograca ricardograca moved this from To do to In progress in Version 1.0.0 Jan 17, 2019
Revert to npm package names for installing DB wrappers
Copy link
Member

@ricardograca ricardograca left a comment

Looks great. Thanks for the contribution.

@ricardograca ricardograca merged commit 46cba13 into bookshelf:master Jan 17, 2019
1 check passed
Version 1.0.0 automation moved this from In progress to Done Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Version 1.0.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants