Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker-compose.yml default postgres user #1972

Merged
merged 1 commit into from Apr 14, 2019
Merged

Fix Docker-compose.yml default postgres user #1972

merged 1 commit into from Apr 14, 2019

Conversation

@NelsonFrancisco
Copy link
Contributor

@NelsonFrancisco NelsonFrancisco commented Apr 13, 2019

The user was set as "root" with no password.
When running the tests, it stated that "postgres" user was not available.
This happened because postgres image was being built with the user "root"

Introduction

Fix docker-compose user to use the postgres default one, so the tests can run.

Fixes #1971.

Motivation

You should be able to run the tests with only the following commands:

$ npm i
$ docker-compose up -d
$ npm test

Proposed solution

Pretty simple, just remove the defined user, and let it fallback to the postgres image default user.

Alternatives considered

Well, maybe we could change the user being set for the tests, and set it as root. But that's adding code, whereas removing code is more elegant IMO.

The user was set as "root" with no password.
When running the tests, it stated that "postgres" user was not available.
This happened because postgres image was being built with the user "root"
Copy link
Member

@ricardograca ricardograca left a comment

I'm not using the Docker setup, but I'm assuming this was tested and works properly.

@ricardograca ricardograca merged commit 28c075f into bookshelf:master Apr 14, 2019
1 check passed
@ricardograca
Copy link
Member

@ricardograca ricardograca commented Jun 13, 2019

This was released in version 0.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants