Fix Docker-compose.yml default postgres user#1972
Merged
ricardograca merged 1 commit intobookshelf:masterfrom Apr 14, 2019
NelsonFrancisco:2019-04-13-docker-user
Merged
Fix Docker-compose.yml default postgres user#1972ricardograca merged 1 commit intobookshelf:masterfrom NelsonFrancisco:2019-04-13-docker-user
ricardograca merged 1 commit intobookshelf:masterfrom
NelsonFrancisco:2019-04-13-docker-user
Conversation
The user was set as "root" with no password. When running the tests, it stated that "postgres" user was not available. This happened because postgres image was being built with the user "root"
ricardograca
approved these changes
Apr 14, 2019
Member
ricardograca
left a comment
ricardograca
left a comment
There was a problem hiding this comment.
I'm not using the Docker setup, but I'm assuming this was tested and works properly.
Member
|
This was released in version 0.15.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user was set as "root" with no password.
When running the tests, it stated that "postgres" user was not available.
This happened because postgres image was being built with the user "root"
Introduction
Fix docker-compose user to use the postgres default one, so the tests can run.
Fixes #1971.
Motivation
You should be able to run the tests with only the following commands:
$ npm i $ docker-compose up -d $ npm testProposed solution
Pretty simple, just remove the defined user, and let it fallback to the postgres image default user.
Alternatives considered
Well, maybe we could change the user being set for the tests, and set it as root. But that's adding code, whereas removing code is more elegant IMO.