-
Notifications
You must be signed in to change notification settings - Fork 577
Update dependencies #1991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #1991
Conversation
|
@ricardograca Do you think version 0.18 should be explicitly excluded from the supported range? (not sure if npm supports multiple intervals for peer dependencies, though) |
|
Good question. I've played a bit with https://semver.npmjs.com/ and came up with this: I don't know if versions older than 0.15.0 still work, but if anyone still needs them they would have to use an older version of Bookshelf anyway since both Knex and Bookshelf dropped Node 4 support in the mean time. |
|
Never mind. Excluding versions 0.18.x is only important for |
|
@ricardograca Are you saying that 0.18 will work fine with bookshelf in production? You only access internal dirs inside tests but not in production code? |
|
Yes, that's it. Sorry about not realizing this sooner. We should stick to your previous commit in terms of |
|
Done. |
|
All green now! Thanks a lot 😃 |
First and foremost this enables support for knex 0.19.0 (that should work out-of-the-box, since sources were moved from
srctolibagain), but also bumps several in-range dependencies in non-breaking way.Closes #1988.