Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1991

Merged
merged 4 commits into from Jul 11, 2019

Conversation

@kibertoad
Copy link
Contributor

commented Jul 11, 2019

First and foremost this enables support for knex 0.19.0 (that should work out-of-the-box, since sources were moved from src to lib again), but also bumps several in-range dependencies in non-breaking way.

Closes #1988.

@kibertoad

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@ricardograca Do you think version 0.18 should be explicitly excluded from the supported range? (not sure if npm supports multiple intervals for peer dependencies, though)

@ricardograca

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Good question. I've played a bit with https://semver.npmjs.com/ and came up with this:

0.15.0 - 0.17.6 || ^0.19.0

I don't know if versions older than 0.15.0 still work, but if anyone still needs them they would have to use an older version of Bookshelf anyway since both Knex and Bookshelf dropped Node 4 support in the mean time.

@ricardograca

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Never mind. Excluding versions 0.18.x is only important for devDependencies but since we're upgrading to 0.19.0 explicitly there it's not an issue.

package.json Outdated Show resolved Hide resolved
@kibertoad

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@ricardograca Are you saying that 0.18 will work fine with bookshelf in production? You only access internal dirs inside tests but not in production code?

@ricardograca

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Yes, that's it. Sorry about not realizing this sooner. We should stick to your previous commit in terms of peerDependencies. Do you mind excluding Node.js 6 jobs from Travis as well?

@kibertoad

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

Done.

@ricardograca

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

All green now! Thanks a lot 😃

@ricardograca ricardograca added this to To do in Version 1.0.0 via automation Jul 11, 2019
@ricardograca ricardograca merged commit 8aedf85 into bookshelf:master Jul 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Version 1.0.0 automation moved this from To do to Done Jul 11, 2019
@kibertoad kibertoad deleted the kibertoad:chore/update-dependencies branch Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 1.0.0
  
Done
2 participants
You can’t perform that action at this time.