Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pagination plugin to core #1992

Merged
merged 5 commits into from Jul 15, 2019

Conversation

@ricardograca
Copy link
Member

commented Jul 14, 2019

Introduction

Move the pagination plugin to core Bookshelf.

Motivation

This is a very useful plugin and its functionality should be part of core since it's almost always used and, in fact, even the documentation has .fetchPage() as a Model method, even though it's currently only available if you call .plugin('pagination').

Proposed solution

Base functionality is moved to the lib/helpers.js file so it can be shared between model and collection methods. New fetchPage methods are added to Model and Collection. No functionality was removed.

@ricardograca ricardograca referenced this pull request Jul 14, 2019
3 of 3 tasks complete
@ricardograca ricardograca merged commit b89331c into master Jul 15, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
github/pages GitHub Pages successfully built your site.
Details
@ricardograca ricardograca deleted the rg-core-pagination branch Jul 15, 2019
@ricardograca ricardograca referenced this pull request Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.