Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move visibility plugin to core #1993

Merged
merged 7 commits into from Jul 21, 2019
Merged

Move visibility plugin to core #1993

merged 7 commits into from Jul 21, 2019

Conversation

@ricardograca
Copy link
Member

@ricardograca ricardograca commented Jul 18, 2019

Introduction

Move the visibility plugin to core Bookshelf.

Motivation

This is a very useful plugin and its functionality is similar to the omitNew and shallow options of model#serialize() which are already part of core.

Proposed solution

Functionality is moved to the BaseModel#serialize() method. New hidden and visible properties are explicitly added to the BaseModel prototype. No functionality was removed.

Note that some tests were moved to the unit tests section since that's what they were.

@ricardograca ricardograca merged commit a40d0bf into master Jul 21, 2019
2 checks passed
@ricardograca ricardograca deleted the rg-core-visibility branch Jul 21, 2019
@ricardograca ricardograca mentioned this pull request Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant