Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all built-in plugins #2000

Merged
merged 9 commits into from Aug 10, 2019

Conversation

@ricardograca
Copy link
Member

commented Aug 9, 2019

Introduction

Removes all built-in plugins.

Motivation

These are additions to core and are not part of the main functionality of Bookshelf, so they should be removed. For more information see the associated issue.

Closes #1997.

Proposed solution

Removes all plugins, related tests, modifies bookshelf.plugin() so that it doesn't try to load plugins from ./plugins and shows warning messages if a user tries to load one of the plugins that was removed. The warning message includes a link to the migration guide.

@ricardograca ricardograca changed the title Rg remove plugins Remove all built-in plugins Aug 9, 2019
@ricardograca ricardograca merged commit 97ea1e9 into master Aug 10, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ricardograca ricardograca deleted the rg-remove-plugins branch Aug 10, 2019
@ricardograca ricardograca referenced this pull request Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.