Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update count methods docs #2013

Merged
merged 4 commits into from Sep 10, 2019
Merged

Update count methods docs #2013

merged 4 commits into from Sep 10, 2019

Conversation

@ricardograca
Copy link
Member

@ricardograca ricardograca commented Sep 9, 2019

Introduction

This updates the documentation for all count() methods. The biggest change is linking them all to the Model#count method that contains information about the return value type in PostgreSQL.

Motivation

It's a bit unexpected that the count() methods return strings in PostgreSQL, so this tries to help with that by making it more clear. There is also a solution in case the user would like to change the type parser to return numbers instead.

Fixes #1275.

References

@ricardograca ricardograca merged commit 750c289 into master Sep 10, 2019
2 checks passed
@ricardograca ricardograca deleted the rg-count-docs branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant