Fix JSON.stringify causing TypeErrors

[anajavi]

• Related Issues: Bookshelf 1.0.0 json serializing fails with TypeError. #2028

Introduction

Fix JSON.stringify throwing TypeError if Model object is placed as object property or in an array.

Motivation

JSON.stringify calls .toJSON on object to be serialized. When called in array, it passes index as parameter to .toJSON. When called in object it passes the property name as parameter:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#toJSON_behavior

Bookshelf model accepts options object as parameter for toJSON, it however does not check if passed parameter is object before trying to put properties in it. This results in TypeError: Cannot create property 'visibility' on string 'propertyname'

Proposed solution

The proposed solution is to check if options is really an object by checking it with lodash.isPlainObject.

Current PR Issues

Not benchmarked this, so can't know the performance implications.

Alternatives considered

Simpler Object check might be more performant. One from redux:
https://github.com/reduxjs/redux/blob/master/src/utils/isPlainObject.ts

[ricardograca]

Looks great, but the simpler object check would be preferable.

[anajavi]

I hope you can release this fix soon, as it is blocking upgrade to 1.0 for me.

[ricardograca]

Looks good.

[ricardograca]

This will be released very soon as there's no reason not to.