Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of arguments in Model#save doclet #2030

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@ricardograca
Copy link
Member

commented Oct 5, 2019

  • Related Issues: #902

Introduction

The number of arguments in the documentation for Model#save shows 4 arguments, when in reality it should be 2, with the possibility of 3 in a special case.

Motivation

Fixes #902.

- This encourages people to use the object argument instead of the 
`key`, `value` option while also mentioning that's a possibility.
@ricardograca ricardograca added the docs label Oct 5, 2019
@ricardograca ricardograca merged commit 2d16907 into master Oct 6, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ricardograca ricardograca deleted the rg-save-doc branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.