Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of arguments in Model#save doclet #2030

Merged
merged 1 commit into from Oct 6, 2019
Merged

Conversation

ricardograca
Copy link
Member

Introduction

The number of arguments in the documentation for Model#save shows 4 arguments, when in reality it should be 2, with the possibility of 3 in a special case.

Motivation

Fixes #902.

- This encourages people to use the object argument instead of the 
`key`, `value` option while also mentioning that's a possibility.
@ricardograca ricardograca merged commit 2d16907 into master Oct 6, 2019
@ricardograca ricardograca deleted the rg-save-doc branch October 6, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.save() documentation shows four parameters.
1 participant