Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to disable running the count query on fetchPage #2045

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Added ability to disable running the count query on fetchPage #2045

merged 2 commits into from
Jan 31, 2020

Conversation

alechirsch
Copy link
Contributor

Adds the ability to disable running the count query on fetchPage

ricardograca
ricardograca requested changes Dec 18, 2019
View reviewed changes
Copy link
Member

@ricardograca ricardograca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't mention that you intended to remove the entire pagination object.

test/integration/collection.js Outdated Show resolved Hide resolved
@alechirsch
Copy link
Contributor Author

@ricardograca Any thoughts on this?

@ricardograca ricardograca merged commit e7d81f5 into bookshelf:master Jan 31, 2020
ricardograca
ricardograca reviewed Jan 31, 2020
View reviewed changes
Copy link
Member

@ricardograca ricardograca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks, and sorry for the delay.

@ricardograca ricardograca mentioned this pull request Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardograca ricardograca ricardograca requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alechirsch @ricardograca