Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to disable running the count query on fetchPage #2045

Merged
merged 2 commits into from Jan 31, 2020

Conversation

@alechirsch
Copy link
Contributor

alechirsch commented Dec 18, 2019

Adds the ability to disable running the count query on fetchPage

Copy link
Member

ricardograca left a comment

You didn't mention that you intended to remove the entire pagination object.

test/integration/collection.js Outdated Show resolved Hide resolved
@alechirsch

This comment has been minimized.

Copy link
Contributor Author

alechirsch commented Jan 10, 2020

@ricardograca Any thoughts on this?

@ricardograca ricardograca merged commit e7d81f5 into bookshelf:master Jan 31, 2020
2 checks passed
2 checks passed
LGTM analysis: JavaScript No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Copy link
Member

ricardograca left a comment

All good. Thanks, and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.