-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Knex dep to allow 0.20.x #2049
Conversation
https://github.com/knex/knex/blob/master/CHANGELOG.md#0200---25-october-2019 Includes a small lint fix and updates package.json>engines>node to specify 8+. I looks like Bookshelf already dropped support for Node 6 w/ 735f2ac, but this config was forgotten.
fe2576f
to
64d0e43
Compare
The change in minimum supported Node version is a bit troublesome since it's a breaking change. Let me think about this for a few more days. |
Be aware that Knex dropped support for Node 6 back in 0.18.0. |
Right, that's a good point, but Bookshelf still supports older versions of Knex as you can see in I'll create a review to reflect these points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still support Node.js 6 technically, although not very actively.
package.json
Outdated
@@ -85,6 +85,6 @@ | |||
"license": "MIT", | |||
"readmeFilename": "README.md", | |||
"engines": { | |||
"node": ">=6" | |||
"node": ">=8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this change? It's not correct since it's still possible to run on Node 6 if you install the correct version of Knex as listed in peerDependencies
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. I put it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the contribution.
https://github.com/knex/knex/blob/master/CHANGELOG.md#0200---25-october-2019
Includes a small lint fix and updates package.json>engines>node to specify 8+.
I looks like Bookshelf already dropped support for Node 6 w/ 735f2ac, but this config was forgotten.
Fixes #2048